WIP: actor based state handling, streaming container stats and podman events#80
Open
WIP: actor based state handling, streaming container stats and podman events#80
Conversation
This was referenced Feb 24, 2021
|
|
Contributor
|
Hi @towe75, this looks great. What would be needed to move this forward? Also I See that you are restarting the stats/event streams after some delay if the fail. Wouldn't that mean that we loose events? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals of this branch:
General idea is to replace the mutex based task store with a message based actor. The actors mailbox, a simple channel, serializes all requests and makes explicit locking unnecessary in a lot of cases.
It's expected that these changes greatly improve the performance of this plugin.
One bug that i found while working on the branch: containers/podman#8864